Closed fgeorgsson closed 5 months ago
Hey @max-mironov, could you take a look at this?
@amchew Why are you giving this to max, it's a core services command not codepush?
And really the arguments should be case insensitive and converted internally to the right strings. We shouldn't be making users have to remember specific magic strings.
@christav we've discussed - thanks, yes it's a core services command.
@pcguru thanks for the useful feedback on the arguments, error message and documentation.
Arguments and error message It would make more sense if the arguments are case-insensitive for the user. This is in our backlog. FYI, the valid OS strings are Android, iOS, macOS, Tizen, tvOS, Windows and the valid platform strings are Java, Objective-C-Swift, UWP, Cordova, React-Native, Xamarin.
On documentation I've submitted a PR for the edits in the documentation, you should see the updates soon.
As we do not have plans to add support for this feature in the next year, I'm closing the issue.
When creating an app any error messages from the server are ignored.
The argument should be "iOS", not "ios", and "Android", not "android". The error message could be more helpful.
The command shown in the migration guide is wrong: https://docs.microsoft.com/en-us/appcenter/distribution/codepush/migrationguide