microsoft / appcenter-sdk-android

Development repository for the App Center SDK for Android
Other
276 stars 134 forks source link

Decouple versioning of sasquatch app from SDK #1662

Closed shadyabarada closed 1 year ago

shadyabarada commented 1 year ago

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

Description

Currently the Sasquatch App version is coupled with the AppCenter Android SDK version due to the unity of the versioning in the versions.gradle file.

This coupling will raise an issue when trying to test the distribute feature with the latest SDK module, here's an example scenario: I want to verify that the distribute feature works as expected for the new app center sdk version (5.0.0) If I downgrade the version from the versions.gradle file (let's say to 4.0.0) for the sake of downgrading the Sasquatch application to test the distribute behaviour, the sdk's version is thus downgraded as well (which is not what we want because we want to actually test the behaviour of the sdk against version 5.0.0 😊)

Therefore, it makes sense for the Sasquatch app to have its own versioning criteria that does not get affected by the SDK. One of the solutions can be overriding the global (versions.gradle) versioning in the Sasquatch's build.gradle.

Related PRs or issues

List related PRs and other issues.

Misc

Add what's missing, notes on what you tested, additional thoughts or questions.

thewulf7 commented 1 year ago

@shadyabarada planning to merge it?