microsoft / appcenter-sdk-apple

Development repository for the App Center SDK for iOS, macOS and tvOS.
Other
565 stars 224 forks source link

Expose MSACBinary and MSACThread as they are props of MSACErrorReport #2549

Open DmitriyKirakosyan opened 2 weeks ago

DmitriyKirakosyan commented 2 weeks ago

Things to consider before you submit the PR:

Description

This PR makes MSACBinary and MSACThread public classes, as they are part of public API of MSACErrorReport.

Related PRs or issues

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.96%. Comparing base (8b039c9) to head (ea2a0f6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2549 +/- ## =========================================== + Coverage 94.88% 94.96% +0.07% =========================================== Files 141 100 -41 Lines 13324 8615 -4709 =========================================== - Hits 12643 8181 -4462 + Misses 681 434 -247 ``` | [Flag](https://app.codecov.io/gh/microsoft/appcenter-sdk-apple/pull/2549/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [MacCatalyst](https://app.codecov.io/gh/microsoft/appcenter-sdk-apple/pull/2549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `94.34% <ø> (-0.12%)` | :arrow_down: | | [iOS](https://app.codecov.io/gh/microsoft/appcenter-sdk-apple/pull/2549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `95.13% <ø> (+0.19%)` | :arrow_up: | | [macOS](https://app.codecov.io/gh/microsoft/appcenter-sdk-apple/pull/2549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `94.08% <ø> (-0.23%)` | :arrow_down: | | [tvOS](https://app.codecov.io/gh/microsoft/appcenter-sdk-apple/pull/2549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | `94.22% <ø> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.