microsoft / appcenter-sdk-react-native

Development repository for the App Center SDK for React Native
Other
407 stars 135 forks source link

Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated. #1033

Open dhafagk opened 3 weeks ago

dhafagk commented 3 weeks ago

Description

After updating the gradle to 8.1.1, always failed when build.

Execution failed for task ':appcenter-analytics:processDebugManifest'.

A failure occurred while executing com.android.build.gradle.tasks.ProcessLibraryManifest$ProcessLibWorkAction Incorrect package="com.microsoft.appcenter.reactnative.analytics" found in source AndroidManifest.xml: .../node_modules/appcenter-analytics/android/src/main/AndroidManifest.xml. Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported. Recommendation: remove package="com.microsoft.appcenter.reactnative.analytics" from the source AndroidManifest.xml: .../node_modules/appcenter-analytics/android/src/main/AndroidManifest.xml.

the error happen for Appcenter, Appcenter Analytic, and Appcenter Crashes.

Repro Steps

  1. use gradle 8.1.1 and react native 0.72+
  2. build using ./gradlew build --warning-mode all

Details

  1. Which version of the App Center SDK are you using?
    • v5.0.1
  2. Which OS version did you experience the issue on?
    • Android
  3. What device version did you see this error on? Were you using an emulator or a physical device?
    • N/A
  4. What third party libraries are you using?
    • example
  5. Run the following command and paste the output below: react-native info

System: OS: macOS 14.1.1 CPU: (8) arm64 Apple M1 Memory: 111.88 MB / 8.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.9.0 path: /var/folders/bn/grjdkyvn55q3dg1dfg1r8x7h0000gq/T/yarn--1719565300972-0.6953485893092728/node Yarn: version: 1.22.19 path: /var/folders/bn/grjdkyvn55q3dg1dfg1r8x7h0000gq/T/yarn--1719565300972-0.6953485893092728/yarn npm: version: 10.1.0 path: ~/.nvm/versions/node/v20.9.0/bin/npm Watchman: version: 2023.10.30.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.12.1 path: /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms:

MikhailSuendukov commented 2 weeks ago

Hello, and thank you for reaching out to us. I have prepared a pull request to move the namespace declaration to the build.gradle file.

jrobichaud commented 5 days ago

@MikhailSuendukov will this fix be available soon?

There is a deadline for the end of august to make a new builds with Android Target SDK 34.

Android Target SDK 34 requires gradle 8.1.1.

Thanks.

MikhailSuendukov commented 1 day ago

@jrobichaud The fix has been merged into the develop branch. Could you please test the changes from this PR and confirm if the issue is resolved?