microsoft / appcenter

Central repository for App Center open source resources and planning.
https://appcenter.ms
Creative Commons Attribution 4.0 International
1.01k stars 223 forks source link

[Feature] Clone branch configurations #22

Closed SandroMachado closed 5 years ago

SandroMachado commented 5 years ago

What App Center service does this feature apply to? Build system

Describe the solution you'd like We should be able to copy build configurations to other branches.

Additional context Every time we want to create a build from a branch, we need to copy all the configurations. The objective of this feature is to simplify this process.

nilofer commented 5 years ago

Hi @SandroMachado, thanks for this feature request! We aim to make the process as simple for you as possible, and this could definitely help. We'll keep this issue open to track total interest in this ability.

hitmanmcc commented 5 years ago

Can we please make this happen? It's a useful feature!

adcuz commented 5 years ago

This would be very useful, currently it is really difficult when you have many environment variables. I have resorted to building a tool dedicated to mass-updating them via the API.

struct78 commented 5 years ago

+1

Being able to automatically clone configuration based off a feature branch's parent would be good too.

RWOverdijk commented 5 years ago

Yes please, this would be really nice. Feature builds are near impossible without configuring each branch now.

I haven't tried this yet but I think it should be possible using these two APIs:

patniko commented 5 years ago

The issue with those API's are the missing secrets @RWOverdijk. We need to do some work on our end to allow you to clone the configs with secrets, certificate, provisioning profiles, keystores, etc intact.

RWOverdijk commented 5 years ago

Maybe configs shouldn't be branch based at all? Maybe build configs should be their own thing. That way you can add powerful features such as wildcard branch names (feature/* for example).

That would be really really neat 😄

Met vriendelijke groet / Kind regards,

Roberto Wesley Overdijk

SpoonX Founder

M. +31 (0)6 15 55 32 43 W. www.spoonx.nl E. wesley@spoonx.nl KvK. 60422696 On 15 Feb 2019, 20:12 +0100, Patrick Nikoletich notifications@github.com, wrote:

The issue with those API's are the missing secrets @RWOverdijk. We need to do some work on our end to allow you to clone the configs with secrets, certificate, provisioning profiles, keystores, etc intact. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

armyofmarkness commented 5 years ago

Being able to clone build configurations would be very useful.

patniko commented 5 years ago

Adding this to next months iteration plan so we can start designing a proper solution for this.

ogezue commented 5 years ago

On buddy build there is a default configuration that is applied automatically. Developers can override it if needed. Please copy every feature of buddybuild as this has been the best mobile ci/cd on the market (feedback by screenshot, ...)

RWOverdijk commented 5 years ago

Yes. I second that. But, buddybuild has betrayed us all. Leave out the betrayal bit when cloning features.

I cri evrytim :(

chrisheninger commented 5 years ago

From what I've been building– the biggest pain point has been needing to re-upload the provisioning profile, certificates, or keystore each time I want to deploy a new branch.

If cloning branch configurations will also pull the signing info over– this feature will be amazing. 🙏

appfabtech commented 5 years ago

Yes. I second that. But, buddybuild has betrayed us all. Leave out the betrayal bit when cloning features.

I cri evrytim :(

Don't tell me, I met them in october 2017 in Verona for #pragmamark conference. And they convinced me to move on their platform. And they assured me they would never sell... They already sold to apple.

nilofer commented 5 years ago

Added a PR for our initial proposal for this feature - leave any feedback you have on this experience!

yyou commented 5 years ago

Instead of implementing something "copying settings from another build configuration" in the build configuration UI (if my understanding is correct), how about create a new UI for users (mainly developer) to maintain a list of build configurations. User can create / edit / delete / copy-from-another a build configuration in this UI. then in the current branch list UI, we don't need to open the build configuration by clicking the small icon at the right side. We just "link" the branch with a build configuration by selecting a build configuration from a drop-down list.

RWOverdijk commented 5 years ago

@yyou take a look at the proposal pr and the comments. I share your opinion and it's written down there already.

jjhampton commented 5 years ago

I agree with @yyou 's comment - it would be useful if build configurations were not strongly coupled to branches.

dgobaud commented 5 years ago

:+1: really need this!

marstall commented 5 years ago

or configure builds via a file checked into your repo, a la chef?

RWOverdijk commented 5 years ago

@marstall There are passwords involved. Please don't put that in your repository.

marstall commented 5 years ago

@rwoverdijk - agreed. recommend using ENV vars for sensitive stuff like that. there are more advanced ways - see chef data bags, ansible vault ... worth a dive.

abdeweese commented 5 years ago

or configure builds via a file checked into your repo, a la chef?

This is the answer. I just created a similar feature request here: https://github.com/microsoft/appcenter/issues/437

piterwilson commented 5 years ago

Decoupling configurations from branches would be amazing. At the moment i am "cloning" (via branchConfigurations_get and branchConfigurations_create ) from my develop branch but it seems somehow less than ideal. Configurations could be their own thing, which can be applied to branches.

nilofer commented 5 years ago

We have shipped the ability to clone existing branch configurations today! Take a look at our documentation for more info. Happy building! bitmoji