search

microsoft / appcenter

Central repository for App Center open source resources and planning.
https://appcenter.ms
Creative Commons Attribution 4.0 International
1.01k stars 223 forks source link

Show InnerExceptions in AppCenter issue report #2294

Open tranb3r opened 3 years ago

tranb3r commented 3 years ago

Describe the solution you'd like In AppCenter issue report, only the top level exception (message and stacktrace) is shown. I think showing InnerExceptions (message and stacktrace) as well is critical for debugging. This information is available in the RAW tab, so why not showing it in the STACKTRACE tab as well?

chm-tm commented 2 years ago

Note that I actually get outer stack traces for Crashes, but not for Errors, using Windows Desktop App. This doesn't include outer exception messages.

The format of the error report is quite different for Crashes and Errors, and I'm wondering about the requirements causing this difference.

ghost commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

tranb3r commented 2 years ago

Could you please fix it instead of closing it ? Thank you.

ghost commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

chm-tm commented 2 years ago

I still wouldn't appreciate automatic closing of this issue.

timdinhdotcom commented 2 years ago

I notice that with version 4.5.0.

If we have this outer exception 

Newtonsoft.Json.JsonSerializationException: Error converting value {null} to type 'System.Guid'. Path 'timesheets[48].uid', line 1, position 1122505.

and this inner exception

System.ArgumentException: Could not cast or convert from {null} to System.Guid.

then app centre would show like this

Newtonsoft.Json.JsonSerializationException: Could not cast or convert from {null} to System.Guid.

Note how the exception type is the outer exception but the message is actually from the inner exception.

I think it should show like how it shown if you perform ToString() on the exception object rather than attempting to manipulate the exception into some shape or form.

So the above exception output would be

Newtonsoft.Json.JsonSerializationException: Error converting value {null} to type 'System.Guid'. Path 'timesheets[48].uid', line 1, position 1122505. ---> System.ArgumentException: Could not cast or convert from {null} to System.Guid.
.
.
.
ghost commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

tranb3r commented 2 years ago

I think I'm going to try crashlytics...

ghost commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

chm-tm commented 2 years ago

I still wouldn't appreciate automatic closing of this issue.

ghost commented 2 years ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

chm-tm commented 2 years ago

This isn't stale for our purposes.

ghost commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

gabrielweyer commented 1 year ago

This issue is still present and still relevant.

ghost commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

gabrielweyer commented 1 year ago

This issue is still present and still relevant.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

gabrielweyer commented 1 year ago

This is still relevant.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

microsoft-github-policy-service[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs within 15 days of this comment.

gabrielweyer commented 1 year ago

This is still relevant.

LathanHarper commented 11 months ago

This is a huge hole in the Microsoft game for actually using the product for what it's intended.. how much value is there in sending exceptions to app center if you cant see them? I wouldnt want my bonus dependent on it - wait! my bonus IS dependent on me using this efficiently -- so please don't close this as stale when it doesnt have a lot of activity because people have started to just accept that microsoft stuff prolly wont actually do what you need when the time comes unless you do all the research yourself in the reams of info on MS learn (great stuff by the way) This is intended to be an encouragement to treat 'developers with needs' with the same empathy you expect deserve. PS - I hope this reaches a human, I am skeptical.