search

microsoft / applicationinsights-angularplugin-js

MIT License
31 stars 17 forks source link

Setup Husky and Prettier #114

Closed arturovt closed 1 year ago

arturovt commented 1 year ago

I didn't run Prettier on the workspace files, maybe you'd want re-visit the rules.

MSNev commented 1 year ago

Internally we are supposed to be using eslint for enforcing / formatting the code. So at this point I don't think we will be able to include this PR.

arturovt commented 1 year ago

Internally we are supposed to be using eslint for enforcing / formatting the code. So at this point I don't think we will be able to include this PR.

Should I then setup eslint-config-prettier except?

MSNev commented 1 year ago

Potentially, yes. If you look at the main AI project you will see the .eslintrc file that we use and while it uses grunt to "run" it this project doesn't use grunt (at least at the moment) -- which is probably how this repo got missed during initial creation.

siyuniu-ms commented 1 year ago

The request is solved in an alternative way in #119.