microsoft / aroworkshop

Azure Red Hat OpenShift workshop
Creative Commons Attribution 4.0 International
58 stars 123 forks source link

Issues with vue version mismatch #46

Closed ahmedsza closed 4 years ago

ahmedsza commented 4 years ago

when the vue based container runs, I got a bunch of errors around a mismatch with versions of vue (forget exact message but similar to https://stackoverflow.com/questions/55906997/vue-packages-version-mismatch) Fixed it by setting "vue": "2.6.10" and "vue-template-compiler": "2.6.10", in package.json

sabbour commented 4 years ago

Thanks for picking this up. Looks like there was a breaking change. I'll update the app.

sabbour commented 4 years ago

@ahmedsza I don't have an ARO cluster handy to try this, but can you add/update the following dependencies in package.json (under devDependencies):

Are you saying changing to vue 2.6.10 worked?

ahmedsza commented 4 years ago

Just tested your change and it works. I used this previously (and it worked too)

"vue": "2.6.10", "vue-loader": "^13.0.0", "vue-style-loader": "^3.0.1", "vue-template-compiler": "2.6.10",

sabbour commented 4 years ago

Fixed in https://github.com/microsoft/rating-web/pull/11