microsoft / artifacts-credprovider

The Azure Artifacts Credential Provider enables dotnet, NuGet.exe, and MSBuild to interactively acquire credentials for Azure Artifacts feeds.
MIT License
759 stars 707 forks source link

Remove Azure Active Directory Authentication Library (ADAL) #411

Closed JohnSchmeichel closed 1 year ago

JohnSchmeichel commented 1 year ago

This removes Azure Active Directory Authentication Library (ADAL) support from the credential provider and all associated environment variables.

JohnSchmeichel commented 1 year ago

set NUGET_CREDENTIALPROVIDER_MSAL_ENABLED=true

remove this usage #Resolved


Refers to: test.bat:13 in 07d6c38. [](commit_id = 07d6c38a3d6316a88772d51caeb1eadfbbfa2a21, deletion_comment = False)

JohnSchmeichel commented 1 year ago

set NUGET_CREDENTIALPROVIDER_MSAL_ENABLED=true

"Testing MSAL with broker" Testing "netcoreapp3.1" with NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER=true dotnet run --no-restore --no-build -f "netcoreapp3.1" --project CredentialProvider.Microsoft\CredentialProvider.Microsoft.csproj -- -C -U https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/artifacts-credprovider/nuget/v3/index.json -V Debug Testing "net461" with NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER=true dotnet run --no-restore --no-build -f "net461" --project CredentialProvider.Microsoft\CredentialProvider.Microsoft.csproj -- -C -U https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/artifacts-credprovider/nuget/v3/index.json -V Debug Testing "net6.0" with NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER=true dotnet run --no-restore --no-build -f "net6.0" --project CredentialProvider.Microsoft\CredentialProvider.Microsoft.csproj -- -C -U https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/artifacts-credprovider/nuget/v3/index.json -V Debug "Testing MSAL without broker" Testing "netcoreapp3.1" with NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER=false dotnet run --no-restore --no-build -f "netcoreapp3.1" --project CredentialProvider.Microsoft\CredentialProvider.Microsoft.csproj -- -C -U https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/artifacts-credprovider/nuget/v3/index.json -V Debug Testing "net461" with NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER=false dotnet run --no-restore --no-build -f "net461" --project CredentialProvider.Microsoft\CredentialProvider.Microsoft.csproj -- -C -U https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/artifacts-credprovider/nuget/v3/index.json -V Debug Testing "net6.0" with NUGET_CREDENTIALPROVIDER_MSAL_ALLOW_BROKER=false dotnet run --no-restore --no-build -f "net6.0" --project CredentialProvider.Microsoft\CredentialProvider.Microsoft.csproj -- -C -U https://pkgs.dev.azure.com/mseng/PipelineTools/_packaging/artifacts-credprovider/nuget/v3/index.json -V Debug "All tests passed"


In reply to: 1539237895


Refers to: test.bat:13 in 07d6c38. [](commit_id = 07d6c38a3d6316a88772d51caeb1eadfbbfa2a21, deletion_comment = False)