microsoft / artifacts-credprovider

The Azure Artifacts Credential Provider enables dotnet, NuGet.exe, and MSBuild to interactively acquire credentials for Azure Artifacts feeds.
MIT License
759 stars 707 forks source link

Session token cache global lock doesn't work cross-platform #416

Closed JohnSchmeichel closed 7 months ago

JohnSchmeichel commented 1 year ago

As reported by https://github.com/microsoft/artifacts-keyring/issues/59 the global lock used by the session token cache doesn't work cross-platform if there is contention on the cache file.

JohnSchmeichel commented 1 year ago

This usage needs to be addressed: https://github.com/microsoft/artifacts-credprovider/blob/9ccd66d2eca28cae136485e37eef7810634f017e/CredentialProvider.Microsoft/Util/SessionTokenCache.cs#L47

Multiple wait handles that involve a named mutex are not supported cross-platform.

github-actions[bot] commented 1 year ago

This issue has had no activity in 90 days. Please comment if it is not actually stale.

JohnSchmeichel commented 1 year ago

Not stale

github-actions[bot] commented 9 months ago

This issue has had no activity in 90 days. Please comment if it is not actually stale.

JohnSchmeichel commented 9 months ago

Not stale