Closed sailro closed 4 months ago
Thank you for the tip, the workaround solved the issue. It's frustrating that we have to modify all of our Dockerfiles now.
We were affected by this too: we pass the value by means of a variable group so we had to change only the single variable.
Apologies for the breaking change. A new 1.1.1 release to revert has been created and set as latest.
We would like to use System.Text.Json in future versions and env variables with single quotes will need to be updated.
Apologies for the breaking change. A new 1.1.1 release to revert has been created and set as latest.
We would like to use System.Text.Json in future versions and env variables with single quotes will need to be updated.
Thank you for the quick reaction, the grace period is appreciated.
Hello,
Starting with
1.1.0
, the credential provider is now usingSystem.Text.Json
instead ofNewtonSoft.Json
.But this can lead to breaking changes, as in the example below:
We were using docker images like this:
And using them in our AZDO build pipeline (see how we are using single quotes for
endpointCredentials
):As soon as the
1.1.0
was published we hit:Indeed single quotes around string values are not supported by design in
System.Text.Json
.Reference: https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/migrate-from-newtonsoft?pivots=dotnet-9-0
Of course we can fix this by using double-quotes going forward, but this change will probably break several users.
As an immediate workaround, before analyzing the issue we used:
in our docker files to rollback to
1.0.9
.Regards Seb