microsoft / artifacts-credprovider

The Azure Artifacts Credential Provider enables dotnet, NuGet.exe, and MSBuild to interactively acquire credentials for Azure Artifacts feeds.
MIT License
747 stars 709 forks source link

Are the Requirements Correct? #491

Closed twinter-amosfivesix closed 2 months ago

twinter-amosfivesix commented 3 months ago

The requirements say:

dotnet

The default installation requires dotnet SDK version 6.0.x.

While the NuGet credential provider requires the dotnet runtime, the pip artifacts-keyring requires the dotnet SDK.

Questions:

  1. Do I really need the SDK? Can I just use the runtimes? But see question 2
  2. What is the pip artifacts key-ring and why would I care about it? I don't use pip with Azure Artifacts. Do I still need the SDK or can I just use the runtime? This statement in the requirements is pretty cryptic to someone who doesn't use Python and could definitely use some explanation.
  3. Do I really need .NET 6 now that .NET 7 and 8 are out? Or are the requirements really just 6+? If I'm doing .NET 8 development do I really need to install the .NET 8 SDK and the .NET 6 SDK?

Thanks! 😄

embetten commented 3 months ago

Only the .net 6 runtime or higher is required, thanks for pointing that out - we can update the docs.

The artifacts-keyring is for python ecosystem development so you would only care about it if you were installing python packages from an Azure artifacts feed. The artifacts-keyring is a lightweight wrapper for the core cred provider which is why it is referenced in this readme. For the keyring it is currenlty incorrectly requiring the sdk - until we release the next version with this change https://github.com/microsoft/artifacts-keyring/pull/70

twinter-amosfivesix commented 3 months ago

@embetten Thanks!

Any thoughts on the .NET versions? Do I really need 6 or can I just use 8?

embetten commented 3 months ago

You can use 8 - the requirement is the runtime version 6 or greater.

twinter-amosfivesix commented 3 months ago

Can the requirements be updated to add "or later" after "The default installation requires dotnet SDK version 6.0.x"?