microsoft / artifacts-credprovider

The Azure Artifacts Credential Provider enables dotnet, NuGet.exe, and MSBuild to interactively acquire credentials for Azure Artifacts feeds.
MIT License
747 stars 709 forks source link

Managed Identity and Service Principal Support #492

Closed embetten closed 1 month ago

embetten commented 2 months ago

Overview

Design Decisions

Environment Variable

ARTIFACTS_CREDENTIALPROVIDER_FEED_ENDPOINTS

 {"endpointCredentials": [{"endpoint":"http://example.index.json", "clientId":"required", "clientCertificateSubjectName":"optional", "clientCertificateFilePath":"optional"}]}

Will throw error if both clientCertificateSubjectName or clientCertificateFilePath are specified.

JohnSchmeichel commented 2 months ago

using System;

add license header


Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff4b5011ec085c15f3ae33bd0c967a108f0, deletion_comment = False)

JohnSchmeichel commented 2 months ago

using System;

same for all new (non test?) files


In reply to: 2116411091


Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff4b5011ec085c15f3ae33bd0c967a108f0, deletion_comment = False)

JohnSchmeichel commented 2 months ago

using System;

test files too


In reply to: 2116411506


Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff4b5011ec085c15f3ae33bd0c967a108f0, deletion_comment = False)

JohnSchmeichel commented 2 months ago

please address the build warnings as well, there are a few about package conflicts. surprised these are not failing the build :(