Closed embetten closed 1 month ago
using System;
add license header
Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff4b5011ec085c15f3ae33bd0c967a108f0, deletion_comment = False)
using System;
same for all new (non test?) files
In reply to: 2116411091
Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff4b5011ec085c15f3ae33bd0c967a108f0, deletion_comment = False)
using System;
test files too
In reply to: 2116411506
Refers to: CredentialProvider.Microsoft/CredentialProviders/VstsBuildTaskServiceEndpoint/VstsBuildTaskMsalTokenProvidersFactory.cs:1 in 0dceaff. [](commit_id = 0dceaff4b5011ec085c15f3ae33bd0c967a108f0, deletion_comment = False)
please address the build warnings as well, there are a few about package conflicts. surprised these are not failing the build :(
Overview
ARTIFACTS_CREDENTIALPROVIDER_FEED_ENDPOINTS
environment variable with new json schema for MI/SP required fields.VSS_NUGET_EXTERNAL_FEED_ENDPOINTS
environment variable.Design Decisions
VSS_NUGET_EXTERNAL_FEED_ENDPOINTS
to reduce password usage and clarify the environment variable will be available to our other credproviders such as the artifacs-keyring not just NuGet.Environment Variable
ARTIFACTS_CREDENTIALPROVIDER_FEED_ENDPOINTS
endpoint
: required. Feed url to authenticate against.clientId
: required for both MI/SP. For user assigned managed identities enter the Entra client id. For system assigned variables set the value tosystem
.clientCertificateSubjectName
: Subject Name of the certificate located in the My/ CurrentUser or LocalMachine certificate store. Optional field. Only used by SP authentication.clientCertificateFilePath
: File path location of the certificate on the machine. Optional field. Only used by SP authentication.Will throw error if both
clientCertificateSubjectName
orclientCertificateFilePath
are specified.