search

microsoft / artifacts-credprovider

The Azure Artifacts Credential Provider enables dotnet, NuGet.exe, and MSBuild to interactively acquire credentials for Azure Artifacts feeds.
MIT License
747 stars 709 forks source link

Broker: Add ability to pass parent window handle explicitly for Windows broker auth #500

Open seclerp opened 2 weeks ago

seclerp commented 2 weeks ago

We have a headless process that hosts the NuGet credential plugin manager and we are facing issues with the default broker logic which tries to obtain the current process' window handle, as we need to pass a native window handle of another (non-.NET) desktop app process. I think the change will be quite beneficial in such a scenario.

I'm open to discussion in case env-based handle propagation is not the best approach.

seclerp commented 2 weeks ago

@microsoft-github-policy-service agree company="JetBrains"

seclerp commented 2 weeks ago

I have a question - what is a proper workflow for internationalization? Should I update the default Resources.resx only?

seclerp commented 2 weeks ago

Hi @embetten, do you need something else from my side, any concerns? Is there something that prevents this stuff from being merged?