Adding missing dependencies to pyproject

microsoft / aurora

Implementation of the Aurora model for atmospheric forecasting

https://microsoft.github.io/aurora

Other

249 stars 31 forks source link

Adding missing dependencies to pyproject #6

Closed scottcha closed 3 months ago

scottcha commented 3 months ago

Fixes #5

wesselb commented 3 months ago

Thanks for opening a PR too, @scottcha. I'm hesitant to add these packages to the requirements, because that means that they will be installed whenever someone installs microsoft-aurora, even if they don't intend to run the notebook. Instead, I've added some additional instructions to the top of the notebook. Are you happy with that too?

scottcha commented 3 months ago

Sounds reasonable. Just wanted to note that those were required somewhere. Though I thought about it for a few seconds and couldn't think of libraries I would use to load those batches in to your batch prep function besides xarray and netcdf but maybe there are others.