Closed victordibia closed 1 day ago
Should cancellation_token be passed to the input_func etc? ,
I think it may be worth checking if the cancellation token is set in the input function, so user who was asked to provide the input can get feedback when their input was cancelled. The user what was asked to provide the input may not be the user that runs the application. So having the cancellation token as part of the input function's argument is good.
Should input_func get a list of all messages?
Not necessary for now, right?
@ekzhu , @husseinmozannar . This is ready for review. We may need a separate PR down the line on where to add it in the documentation.
I will do my best to take a look today, worst case tomorrow/sunday
While current tutorial shows how to create custom agents, a UserProxyAgent seems to be a common preset and it would be good to have an implementation that can be easily reused as part of the api instead of apps having multiple implementations (e.g., AGS) . This PR is meant to start a design conversation around this.
This PR does the following:
input_func
in constructor that defaults to consoleinput
if nothing is passed.input_func
gets called when the UserProxyAgent gets a message, and returns a stringTo be done:
Why are these changes needed?
Provide some standard/guidance around creating a UserProxyAgent.
Related issue number
Related to #3614
Checks