search

microsoft / automatic-graph-layout

A set of tools for graph layout and viewing
Other
1.36k stars 304 forks source link

GViewer strange zoom behaviour of ZoomToWindow #120

Closed john-e-lewis closed 7 years ago

john-e-lewis commented 7 years ago

The Zoom To Window tool in GViewerGDI will often zoom in too much or will zoom out to much, behaviour is unpredictable from user perspective.

In the original MSAGL release the zoom to window would adjust the display to show the entire area covered by the zoom rectangle.

levnach commented 7 years ago

It should work now.

john-e-lewis commented 7 years ago

Thanks for the fix, the zoom to window feature now works.

Can I request that you undo one of the changes you made when fixing this issue. Specifically,
Commit e5fc7698 'DrawReversibleFrame is broken in winforms, stop using it'

I believe this part of the feature works ok and provides very useful user feedback when selecting the zoom window.

levnach commented 7 years ago

I had a small repro (actually an MSDN sample) on a problem with 'DrawReversibleFrame which does not work on Windows 10 when the items are enlarged. Other users complained too that 'DrawReversibleFrame is broken. I think it is safe to suppress this feature.

john-e-lewis commented 7 years ago

No worries, I will retain it in my local version. FYI, I'm using it successfully on windows 10 and have tried breaking it without success. Maybe, the issue was related to the other fixes you applied that certainly did correct its behaviour.