microsoft / automatic-graph-layout

A set of tools for graph layout and viewing
Other
1.35k stars 304 forks source link

Can the assemblies be strong name signed? #231

Closed twsouthwick closed 4 years ago

twsouthwick commented 4 years ago

I want to include the project in Visual Studio as part of an extension and strong named assemblies are required. This would be a major breaking change, but required for a number of scenarios. Thanks!

levnach commented 4 years ago

I am not sure about this request. Strong naming probably can hurt some users. I would like to hear more opinions.

twsouthwick commented 4 years ago

Here's the guidance from the docs: https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/strong-naming. Yes, it can definitely cause problems if you are not used to them, and I can understand the hesitancy. However, these points lead me to always strong name sign:

So, strong naming allows to reach the broadest audience. Most applications with extension models (such as VS) are strong name signed and so cannot consume libraries that are not.

I'm currently having to build my own version of the library for a project and would rather not. I'm interested if there is any other feedback for this.

levnach commented 4 years ago

@twsouthwick , can you please submit a pull request for this? Thank you!

r-ramesh commented 4 years ago

@levnach @twsouthwick Can you update the NuGet package to contain the strong name signed binaries?