Added Svg Layer Sample to msagl

microsoft / automatic-graph-layout

A set of tools for graph layout and viewing

Other

1.35k stars 302 forks source link

Added Svg Layer Sample to msagl #280

Closed Baudin999 closed 3 years ago

Baudin999 commented 3 years ago

Working on rendering component diagrams using MSAGL. Content of the pull request:

New Project SvgLayerSample
Refactored (most) of the current SvgGraphWriter to a individual components, this is "just an idea" but I think it could work.
Cleaned the Svg API a little, Diagram takes a Drawing graph as parameter and can Run to generate the Svg.

This is my first pull request for MSAGL, please let me know if I should change something.

ghost commented 3 years ago

All CLA requirements met.

levnach commented 3 years ago

Hi @Baudin999 , Thanks for the pull request. I noticed a couple of things: I would rename SvgLayerSample.Svg.Rectangle to RectSvg or something like that, otherwise it will appear in queries for Rectangle from Geometry. Another one is that the node labels in SvgLayerSample have disappeared: noNodeLabels

Baudin999 commented 3 years ago

Hi @levnach ,

I really can't reproduce the missing labels. I select the SvgLayerSample as start-up project and hit F5. The generated svg is automatically copied to clipboard. I paste this svg in something like JS Bin.

When I do this I get an image like:

levnach commented 3 years ago

It was mistake on my side. I was viewing the SVG file with Emacs that did not render it correctly.