Test Failure: RouteEdges_SmallGroups

[rassilon]

This appears to be currently failing due to not using Environment.SpecialFolder to discover where Temp is.

I'll create a PR for this.

[rassilon]

Ok, so after more investigation. After fixing the obvious issue, the next two things I encountered were:

• This test case takes hours upon hours upon hours to run to completion. I haven't seen it run to completion yet for one reason or another.

The kids of failures that I saw occur while it was running currently fall into one of these buckets:

• Exception for: mult=2, i=1792, es=3.99423473700613, graph stored in C:\Users\Administrator\AppData\Local\Temp\2\tmp40BD.tmp, exception: System.InvalidOperationException: Operation is not valid due to the current state of the object. at Microsoft.Msagl.Routing.ConstrainedDelaunayTriangulation.CdtTriangle..ctor(CdtSite a, CdtSite b, CdtSite c, Func`3 createEdgeDelegate) in c:\github\agl\GraphLayout\MSAGL\Routing\ConstrainedDelaunayTriangulation\CdtTriangle.cs:line 61

This appears to be a Debug.Assert that has now been commented out for non-Counter Clockwise triangels which has now been commented out.

• Exception for: mult=2, i=2989, es=4.11105571738959, graph stored in C:\Users\Administrator\AppData\Local\Temp\2\tmpA019.tmp, exception: Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.Fail failed. at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.HandleFailure(String assertionName, String message) at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Fail(String message) at Microsoft.Msagl.UnitTests.DebugAssertRedirector.Fail(String message) in c:\github\agl\GraphLayout\Test\MSAGLTests\Infrastructure\DebugAssertRedirector.cs:line 45 at System.Diagnostics.TraceInternal.Fail(String message) at System.Diagnostics.Debug.Assert(Boolean condition) at Microsoft.Msagl.Routing.ConstrainedDelaunayTriangulation.CdtSweeper.InCircle(CdtSite d, CdtSite a, CdtSite b, CdtSite c) in c:\github\agl\GraphLayout\MSAGL\Routing\ConstrainedDelaunayTriangulation\CdtSweeper.cs:line 707

This appears to be for the same reason. (non-Counter Clockwise triangles) However, this assert hasn't been commented out yet.

• Exception for: mult=4, i=1111, es=0.600446255691557, graph stored in C:\Users\Administrator\AppData\Local\Temp\2\tmp87E6.tmp, exception: Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException: Assert.Fail failed. at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.HandleFailure(String assertionName, String message) at Microsoft.VisualStudio.TestTools.UnitTesting.Assert.Fail(String message) at Microsoft.Msagl.UnitTests.DebugAssertRedirector.Fail(String message) in c:\github\agl\GraphLayout\Test\MSAGLTests\Infrastructure\DebugAssertRedirector.cs:line 45 at System.Diagnostics.TraceInternal.Fail(String message) at System.Diagnostics.Debug.Assert(Boolean condition) at Microsoft.Msagl.Routing.ConstrainedDelaunayTriangulation.CdtSweeper.ShortcutTwoFrontElements(RBNode1 aNode, RBNode1 bNode) in c:\github\agl\GraphLayout\MSAGL\Routing\ConstrainedDelaunayTriangulation\CdtSweeper.cs:line 418

This stems from: Debug.Assert(aElem.RightSite == bElem.LeftSite);

Given how long this test takes I would think it would make sense to either fail this test with an explanation of how extra long it takes to run, or add an Ignore attribute to it.

Thoughts?

Bill