search

microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
134 stars 62 forks source link

chore: Update Wix packages to version 4.0.5 #1013

Closed DaveTryon closed 5 months ago

DaveTryon commented 5 months ago

Details

Update WixToolset.. to address CVE-2024-29188. The existing code does not appear to actually be vulnerable, but this is cheap insurance.

The change was made via Visual Studio, which removed the extra newlines. I'm not a fan of having the tool pull these out but it's not worth the hassle of trying to keep them in if Visual Studio insists on removing them.

Motivation

CVE

Context

Pull request checklist

DaveTryon commented 5 months ago

Seems okay to me, but why remove the empty lines? Were they visually meaningful?

Newlines provide logical grouping. Visual Studio decided to remove them and I didn't want to get into a tug of war with our editing tools

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.64%. Comparing base (4fc19c3) to head (66276e2). Report is 380 commits behind head on main.

:exclamation: Current head 66276e2 differs from pull request most recent head 441fe4c. Consider uploading reports for the commit 441fe4c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1013 +/- ## ========================================== - Coverage 73.70% 71.64% -2.06% ========================================== Files 398 424 +26 Lines 12046 13117 +1071 Branches 0 1416 +1416 ========================================== + Hits 8878 9398 +520 - Misses 3168 3303 +135 - Partials 0 416 +416 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.