Closed sfoslund closed 2 years ago
Please also check the code for instances of using static System.FormattableString;
. TSA flagged these as errors in places where we used interpolated strings for Exception messages. If we're no longer using interpolated strings for Exceptions, then we shouldn't need them.
Please also check the code for instances of using static System.FormattableString;. TSA flagged these as errors in places where we used interpolated strings for Exception messages. If we're no longer using interpolated strings for Exceptions, then we shouldn't need them.
There are a lot of instances of FormattableString that touch a lot of files, so I went ahead and separated that piece into a different PR: https://github.com/microsoft/axe-windows/pull/771
Merging #768 (c696051) into main (4fc19c3) will increase coverage by
0.87%
. The diff coverage is77.36%
.
@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 73.70% 74.57% +0.87%
==========================================
Files 398 420 +22
Lines 12046 12958 +912
==========================================
+ Hits 8878 9664 +786
- Misses 3168 3294 +126
Impacted Files | Coverage Δ | |
---|---|---|
src/Actions/Actions/ControlPatternAction.cs | 0.00% <0.00%> (ø) |
|
src/Actions/Actions/CustomUIAAction.cs | 0.00% <0.00%> (ø) |
|
src/Actions/Actions/ListenAction.cs | 0.00% <0.00%> (ø) |
|
src/Actions/Actions/LoadActionParts.cs | 90.90% <ø> (ø) |
|
src/Actions/Actions/SetDataAction.cs | 0.00% <0.00%> (ø) |
|
...rc/Actions/Attributes/InteractionLevelAttribute.cs | 0.00% <ø> (ø) |
|
src/Actions/Contexts/ElementDataContext.cs | 86.36% <ø> (ø) |
|
src/Actions/Misc/ExtensionMethods.cs | 7.46% <0.00%> (-31.60%) |
:arrow_down: |
src/Actions/Resources/ErrorMessages.Designer.cs | 0.00% <ø> (-55.56%) |
:arrow_down: |
src/Automation/Data/OutputFile.cs | 88.88% <ø> (ø) |
|
... and 233 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Details
Audit/ clean up hardcoded strings throughout the code base in preparation for localizing in the future.
Motivation
Ensure all strings that need to be localized are in resource files, and additionally code cleanliness
Context
Pull request checklist