search

microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

feat(localization): Include .resource.dll files for signing #784

Closed sfoslund closed 1 year ago

sfoslund commented 1 year ago

Details

.resource.dll files were added to signed build output in https://github.com/microsoft/axe-windows/pull/779, but are not actually included in signing yet. This PR adds those files to FilesToSign.

Test run with these changes: https://dev.azure.com/mseng/1ES/_build/results?buildId=18601521&view=results

Motivation

Localization feature work

Pull request checklist

DaveTryon commented 1 year ago

One thought--should we also include these files in the BinSkim checks? Maybe some sort of a glob pattern at https://github.com/microsoft/axe-windows/blob/main/build/signedbuild.yml#L254 ?

sfoslund commented 1 year ago

One thought--should we also include these files in the BinSkim checks?

Good idea, I can do that as a separate PR