microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

feat(localization): Add script to check resource strings for comments #787

Closed sfoslund closed 1 year ago

sfoslund commented 1 year ago

Details

As the resource strings in the core, rules, and ruleselection projects will be localized soon, it is important that we include any necessary translator comments along with those resources. We have gone through and added comments in previous PRs, but this PR adds a script to our PR builds to verify that we continue to have translator notes for all resource strings in those projects.

Motivation

Localization feature

Context

The script does not include the resource files for projects that are not localized right now, since there are quite a lot of strings in those projects that do not have comments yet. If we ever decide to localize those projects, it will be simple to remove them from the exclude list in this script.

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #787 (61f6716) into main (4fc19c3) will increase coverage by 1.03%. The diff coverage is 77.46%.

@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   73.70%   74.73%   +1.03%     
==========================================
  Files         398      421      +23     
  Lines       12046    12983     +937     
==========================================
+ Hits         8878     9703     +825     
- Misses       3168     3280     +112     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/LoadActionParts.cs 90.90% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <ø> (ø)
src/Actions/Contexts/ElementDataContext.cs 86.36% <ø> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 285 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.