Closed DaveTryon closed 1 year ago
Merging #798 (d7327ae) into main (4fc19c3) will increase coverage by
1.03%
. The diff coverage is78.34%
.
@@ Coverage Diff @@
## main #798 +/- ##
==========================================
+ Coverage 73.70% 74.73% +1.03%
==========================================
Files 398 421 +23
Lines 12046 12983 +937
==========================================
+ Hits 8878 9703 +825
- Misses 3168 3280 +112
Impacted Files | Coverage Δ | |
---|---|---|
src/Actions/Actions/ControlPatternAction.cs | 0.00% <0.00%> (ø) |
|
src/Actions/Actions/CustomUIAAction.cs | 0.00% <0.00%> (ø) |
|
src/Actions/Actions/ListenAction.cs | 0.00% <0.00%> (ø) |
|
src/Actions/Actions/LoadActionParts.cs | 90.90% <ø> (ø) |
|
src/Actions/Actions/SetDataAction.cs | 0.00% <0.00%> (ø) |
|
...rc/Actions/Attributes/InteractionLevelAttribute.cs | 0.00% <ø> (ø) |
|
src/Actions/Contexts/ElementDataContext.cs | 86.36% <ø> (ø) |
|
src/Actions/Misc/ExtensionMethods.cs | 7.46% <0.00%> (-31.60%) |
:arrow_down: |
src/Actions/Resources/ErrorMessages.Designer.cs | 0.00% <ø> (-55.56%) |
:arrow_down: |
src/Automation/Data/OutputFile.cs | 88.88% <ø> (ø) |
|
... and 285 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Details
Apply analyzer-led removal of unneeded
this.
prefixes in theCore
project. After locally making the changes in #796, the IDE highlighted thethis.
prefixes that were not needed.Motivation
The code was originally written by folks who used
this.
everywhere because that was the pattern in the team that they came from. Over time, that pattern has fallen by the wayside and now the code is very inconsistent. This PR is part of a series of PRs intended to increase the code consistency by removing unnecessarythis
. usage wherever possible.Context
Pull request checklist