search

microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Update private field names in RulesTest project #818

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

Code standards are very inconsistent throughout the code base. This PR contains the changes needed to make the RulesTests project consistent after locally applying #810. The renames were all done through the IDE, and in most cases the IDE-suggested name was used. In cases where the IDE-supplied name seemed odd, I chose a name that seemed appropriate. There were also several cases where the simplest fix was to make a member static.

Motivation

Improve code consistency and clarity

Context

A separate PR will be used to normalize the use of the readonly keyword in this project

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #818 (baf08c8) into main (4fc19c3) will increase coverage by 1.01%. The diff coverage is 72.29%.

:exclamation: Current head baf08c8 differs from pull request most recent head 8f8b158. Consider uploading reports for the commit 8f8b158 to get more accurate results

@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   73.70%   74.71%   +1.01%     
==========================================
  Files         398      420      +22     
  Lines       12046    12970     +924     
==========================================
+ Hits         8878     9690     +812     
- Misses       3168     3280     +112
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
src/Automation/Data/ScanResult.cs 100.00% <ø> (ø)
src/Automation/Data/WindowScanOutput.cs 100.00% <ø> (ø)
... and 266 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.