microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Normalize readonly usage in RulesTest project #820

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

When we first added the .editorconfig file, we disabled the rule that wants the readonly attribute in the RulesTest project, just to keep the commit from getting even larger. This PR is the second pass that enables the readonly rule in RulesTest, then updates the files as needed.

Motivation

Code consistency

Context

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #820 (01554f0) into main (4fc19c3) will increase coverage by 0.97%. The diff coverage is 79.84%.

:exclamation: Current head 01554f0 differs from pull request most recent head 678edab. Consider uploading reports for the commit 678edab to get more accurate results

@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   73.70%   74.67%   +0.97%     
==========================================
  Files         398      420      +22     
  Lines       12046    12969     +923     
==========================================
+ Hits         8878     9685     +807     
- Misses       3168     3284     +116     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
src/Automation/Data/ScanResult.cs 100.00% <ø> (ø)
src/Automation/Data/WindowScanOutput.cs 100.00% <ø> (ø)
... and 279 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.