microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Miscellaneous cleanup #821

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

A few general cleanup changes:

  1. Disable the dotnet_style_prefer_compound_assignment rule in .editorconfig, since it's a C# 8.0 feature and .NET standard 2.0 assumes C# 7.3 support
  2. Remove private setters that aren't needed. Omitting the private setter means that the property can only be set in the constructor. Methodology was to remove all private setters, then bring back the ones that the compiler said we need
  3. Rename the EventListenerBase.disposedValue property to DisposedValue (it's protected, so the .editorconfig rule didn't catch it). This updated its usage in all derived classes, as well.
  4. Remove some unreferenced fields (called out by the IDE)
  5. Remove extra newlines that are floating around
  6. Run the IDE's code cleanup agent to tidy up using blocks, adjust whitespace in lines, etc. This always cuts a little too deep with the Custom Actions, so some of these changes were manually backed out to allow the build to succeed
Motivation

After this, I think we're .editorconfig clean

Context

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #821 (702b6c0) into main (4fc19c3) will increase coverage by 1.04%. The diff coverage is 80.63%.

@@            Coverage Diff             @@
##             main     #821      +/-   ##
==========================================
+ Coverage   73.70%   74.74%   +1.04%     
==========================================
  Files         398      420      +22     
  Lines       12046    12969     +923     
==========================================
+ Hits         8878     9694     +816     
- Misses       3168     3275     +107     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
src/Automation/Data/ScanResult.cs 100.00% <ø> (ø)
src/Automation/Data/WindowScanOutput.cs 100.00% <ø> (ø)
... and 271 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.