microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Update some properties #828

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

This PR tidies up some properties that I've noticed in the code:

  1. InteractionLevelAttribute.InteractionLevel can be an auto-property
  2. BaseTracker.ProcessId can be a protected property instead of an internal field
  3. ColorPair can be a little simpler it the foreground color and background color are implemented as properties
Motivation

Code clarity and control

Context

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #828 (dbcb1e3) into main (4fc19c3) will increase coverage by 0.98%. The diff coverage is 80.32%.

@@            Coverage Diff             @@
##             main     #828      +/-   ##
==========================================
+ Coverage   73.70%   74.68%   +0.98%     
==========================================
  Files         398      420      +22     
  Lines       12046    12972     +926     
==========================================
+ Hits         8878     9688     +810     
- Misses       3168     3284     +116     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/PrivacyExtensions.cs 100.00% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/AxeWindowsAutomationException.cs 33.33% <ø> (-33.34%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 432 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.