microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Consistently follow IDE0049 #829

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

IDE0049 nudges us toward language-specific type names instead of framework type names, so things like:

Most of the code is already following this rule, but there are some outliers. This PR updates .editorconfig to call out these issues, then also applies the changes across all projects

Motivation

Code consistency

Context

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #829 (9849ed9) into main (4fc19c3) will increase coverage by 0.97%. The diff coverage is 80.19%.

@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
+ Coverage   73.70%   74.67%   +0.97%     
==========================================
  Files         398      420      +22     
  Lines       12046    12969     +923     
==========================================
+ Hits         8878     9685     +807     
- Misses       3168     3284     +116     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/PrivacyExtensions.cs 100.00% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/AxeWindowsAutomationException.cs 33.33% <ø> (-33.34%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 432 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.