microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Add wxs validation/fix gaps #834

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

In https://github.com/microsoft/accessibility-insights-windows/pull/1388, we added a WXS validation check to the AIWin MSI definition to identify gaps that are introduced by package updates (mainly driven by dependabot). It seemed like a good idea to have a similar check for Axe.Windows. When running the test, it identified gaps that had been introduced by package updates, so those are includes in this PR.

Note that since the MSI build is limited release builds, so are the MsiFileTests.

Motivation

Ensure that the CLI always has the expected set of files.

Context

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #834 (9972562) into main (4fc19c3) will increase coverage by 1.02%. The diff coverage is 80.56%.

@@            Coverage Diff             @@
##             main     #834      +/-   ##
==========================================
+ Coverage   73.70%   74.72%   +1.02%     
==========================================
  Files         398      421      +23     
  Lines       12046    12998     +952     
==========================================
+ Hits         8878     9713     +835     
- Misses       3168     3285     +117     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/PrivacyExtensions.cs 100.00% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/AxeWindowsAutomationException.cs 33.33% <ø> (-33.34%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 431 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.