Due to a logic error, files were returned only if a set of excluded files was provided. This empty set was not caught as a problem. These have both been fixed.
We weren't passing the correct component names in 1, so we were returning empty sets of files. This empty set was also not caught as a problem. This has been fixed.
As written, the checker assumed that everything in a component comes from the same build folder, which is OK in this project. For consistency with AIWIn, though, we ignore the source path of the file and validate the set of files in the folder.
There was also 1 place in the WXS file where we were using a component name that was originally derived from a deprecated version of .NET Core. This component and its containing group have been renamed for clarity. This has absolutely no impact on the files included in the MSI package. Happy to move that to a different PR if desired.
Motivation
Make test detect errors (which is why it's there)
Context
It might also make sense to rename ProductComponents to ProductComponentGroup in the WXS file. It's easy to change this at any time if we so desire.
Details
This is the analog to AIWin 1483.
This fixes some issues with the MSI checker:
There was also 1 place in the WXS file where we were using a component name that was originally derived from a deprecated version of .NET Core. This component and its containing group have been renamed for clarity. This has absolutely no impact on the files included in the MSI package. Happy to move that to a different PR if desired.
Motivation
Make test detect errors (which is why it's there)
Context
It might also make sense to rename
ProductComponentstoProductComponentGroupin the WXS file. It's easy to change this at any time if we so desire.Pull request checklist