codecov-commenter
commented
1 year ago Codecov Report
Merging #871 (137a51a) into main (4fc19c3) will increase coverage by
1.08%. The diff coverage is80.70%.
@@ Coverage Diff @@
## main #871 +/- ##
==========================================
+ Coverage 73.70% 74.78% +1.08%
==========================================
Files 398 422 +24
Lines 12046 13017 +971
==========================================
+ Hits 8878 9735 +857
- Misses 3168 3282 +114 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/Actions/Actions/ControlPatternAction.cs | 0.00% <0.00%> (ø) |
|
| src/Actions/Actions/CustomUIAAction.cs | 0.00% <0.00%> (ø) |
|
| src/Actions/Actions/ListenAction.cs | 0.00% <0.00%> (ø) |
|
| src/Actions/Actions/PrivacyExtensions.cs | 100.00% <ø> (ø) |
|
| src/Actions/Actions/SetDataAction.cs | 0.00% <0.00%> (ø) |
|
| ...rc/Actions/Attributes/InteractionLevelAttribute.cs | 0.00% <0.00%> (ø) |
|
| src/Actions/Misc/ExtensionMethods.cs | 7.46% <0.00%> (-31.60%) |
:arrow_down: |
| src/Actions/Resources/ErrorMessages.Designer.cs | 0.00% <ø> (-55.56%) |
:arrow_down: |
| src/Automation/AxeWindowsAutomationException.cs | 33.33% <ø> (-33.34%) |
:arrow_down: |
| src/Automation/Data/OutputFile.cs | 88.88% <ø> (ø) |
|
| ... and 429 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Details
This PR is 1/2 of addressing https://github.com/microsoft/axe-windows/issues/836. It includes the following commits/changes, which can be reviewed separately:
ChromiumComponentsShouldUseWebScannerrule and a new e2e test leveraging the new web view sample added in this PR.Motivation
Addresses issue https://github.com/microsoft/axe-windows/issues/836
Context
This PR only adds the new rule logic but does not do the work to suppress any further errors in descendants of the root "Chrome" element (hence why there are 35 expected errors in the end to end test instead of just 1). A future PR will add the suppression logic separately.
Pull request checklist