microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

feat(chrome-scans): Add filtered framework ids test utility #872

Closed sfoslund closed 1 year ago

sfoslund commented 1 year ago

Details

Adding test utility suggested in https://github.com/microsoft/axe-windows/pull/871#discussion_r1088151744. Initially this PR only leverages the new utility in the 3 tests that are not overlapping with those changed in https://github.com/microsoft/axe-windows/pull/871 to avoid PR conflicts, but I'll either update this PR or that one depending on which gets merged first.

Motivation

Address PR feedback from https://github.com/microsoft/axe-windows/pull/871

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #872 (3b7b958) into main (4fc19c3) will increase coverage by 1.02%. The diff coverage is 80.51%.

:exclamation: Current head 3b7b958 differs from pull request most recent head c7ba61e. Consider uploading reports for the commit c7ba61e to get more accurate results

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   73.70%   74.72%   +1.02%     
==========================================
  Files         398      421      +23     
  Lines       12046    12998     +952     
==========================================
+ Hits         8878     9713     +835     
- Misses       3168     3285     +117     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/PrivacyExtensions.cs 100.00% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/AxeWindowsAutomationException.cs 33.33% <ø> (-33.34%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 428 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.