microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Point WebViewSample to a more stable target #876

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

The WebViewSample app points to www.microsoft.com, which changes frequently. Since the test fails if the number of elements on the page changes, this is a problem. This change points to a web page that changes very infrequently and updates the failure count accordingly.

Motivation

Make unit tests less flaky, unblock PR (#875) that is currently impacted

Context

It might be worth adding the ability to specify the starting page via the command line, but I left that out for now.

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #876 (2adc407) into main (4fc19c3) will increase coverage by 1.06%. The diff coverage is 80.70%.

:exclamation: Current head 2adc407 differs from pull request most recent head dd78176. Consider uploading reports for the commit dd78176 to get more accurate results

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
+ Coverage   73.70%   74.76%   +1.06%     
==========================================
  Files         398      422      +24     
  Lines       12046    13017     +971     
==========================================
+ Hits         8878     9732     +854     
- Misses       3168     3285     +117     
Impacted Files Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/PrivacyExtensions.cs 100.00% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/AxeWindowsAutomationException.cs 33.33% <ø> (-33.34%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 429 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.