microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

chore: Remove rules test category #972

Closed DaveTryon closed 1 year ago

DaveTryon commented 1 year ago

Details

Remove "Axe.Windows.Rules" test category. It was only sporadically used, and wasn't providing any value. After conversation with @RobGallo, we've chosen to remove the attribute from the few cases where it's used.

Motivation

Code consistency

Context

Pull request checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #972 (b767de5) into main (4fc19c3) will increase coverage by 1.16%. Report is 348 commits behind head on main. The diff coverage is 79.38%.

:exclamation: Current head b767de5 differs from pull request most recent head 0e55bfd. Consider uploading reports for the commit 0e55bfd to get more accurate results

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   73.70%   74.86%   +1.16%     
==========================================
  Files         398      424      +26     
  Lines       12046    13117    +1071     
==========================================
+ Hits         8878     9820     +942     
- Misses       3168     3297     +129     
Files Changed Coverage Δ
src/Actions/Actions/ControlPatternAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/CustomUIAAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/ListenAction.cs 0.00% <0.00%> (ø)
src/Actions/Actions/PrivacyExtensions.cs 100.00% <ø> (ø)
src/Actions/Actions/SetDataAction.cs 0.00% <0.00%> (ø)
...rc/Actions/Attributes/InteractionLevelAttribute.cs 0.00% <0.00%> (ø)
src/Actions/Misc/ExtensionMethods.cs 7.46% <0.00%> (-31.60%) :arrow_down:
src/Actions/Resources/ErrorMessages.Designer.cs 0.00% <ø> (-55.56%) :arrow_down:
src/Automation/AxeWindowsAutomationException.cs 33.33% <ø> (-33.34%) :arrow_down:
src/Automation/Data/OutputFile.cs 88.88% <ø> (ø)
... and 143 more

... and 243 files with indirect coverage changes