search

microsoft / axe-windows

Automated accessibility testing engine for Windows applications
MIT License
136 stars 62 forks source link

fix: MSI installer should warn user about unsupported OS. #986

Closed v-singhanjal closed 9 months ago

v-singhanjal commented 9 months ago

Details

MSI installer should warn user about unsupported Operating System. Associated Issue: https://github.com/microsoft/axe-windows/issues/980

Motivation

Fix implemented for:

image

Context

Pull request checklist

codecov-commenter commented 9 months ago

Codecov Report

Attention: 426 lines in your changes are missing coverage. Please review.

Comparison is base (4fc19c3) 73.70% compared to head (37ac55b) 71.70%. Report is 359 commits behind head on main.

:exclamation: Current head 37ac55b differs from pull request most recent head 3f72731. Consider uploading reports for the commit 3f72731 to get more accurate results

Files Patch % Lines
src/Actions/Actions/SelectAction.cs 59.09% 29 Missing and 7 partials :warning:
src/Actions/Trackers/FocusTracker.cs 15.00% 33 Missing and 1 partial :warning:
src/Actions/Actions/GetDataAction.cs 15.15% 27 Missing and 1 partial :warning:
src/CLI/Program.cs 0.00% 28 Missing :warning:
src/Actions/Actions/ListenAction.cs 0.00% 23 Missing :warning:
src/Actions/Actions/DataManager.cs 58.82% 20 Missing and 1 partial :warning:
src/Actions/Trackers/BaseTracker.cs 36.00% 15 Missing and 1 partial :warning:
src/Automation/Resources/ErrorMessages.Designer.cs 40.00% 15 Missing :warning:
src/Core/Bases/A11yElement.cs 65.00% 3 Missing and 11 partials :warning:
src/Actions/Trackers/MouseTracker.cs 50.00% 12 Missing :warning:
... and 44 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #986 +/- ## ========================================== - Coverage 73.70% 71.70% -2.00% ========================================== Files 398 424 +26 Lines 12046 13117 +1071 Branches 0 1416 +1416 ========================================== + Hits 8878 9405 +527 - Misses 3168 3297 +129 - Partials 0 415 +415 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.