search

microsoft / azpipelines-kubernetesUI

This repo contains UI views of a kubernetes cluster and will be used in azure devops pipelines. This UI is hostable outside of azure pipelines product and does not require the UI web server to be running inside the kubernetes cluster.
Other
22 stars 11 forks source link

URL for the job should not be computed #148

Open madhuv-msft opened 5 years ago

madhuv-msft commented 5 years ago

As per the code, uri should not be computed. it should be taken from labels. https://github.com/Microsoft/azure-pipelines-tasks/blob/3d08e79a83e16610b0f4e9531e74dbe5391255b1/Tasks/Common/docker-common/pipelineutils.ts#L28

addLabel(hostName, "build.builduri", "BUILD_BUILDURI", labels);

we are doing the following https://github.com/Microsoft/azpipelines-kubernetesUI/blob/2af2af8a5a0e95d7afd88ce18d18ac69b160d207/src/WebUI/ImageDetails/ImageDetails.tsx#L367

return format("{0}{1}/_build?buildId={2}", teamFoundationCollectionUri, teamProject, runId.toString());

madhuv-msft commented 5 years ago

please note we should not completely rely on builduri, we should also see releaseuri also. just in case if the image is built from the release.