search

microsoft / azpipelines-kubernetesUI

This repo contains UI views of a kubernetes cluster and will be used in azure devops pipelines. This UI is hostable outside of azure pipelines product and does not require the UI web server to be running inside the kubernetes cluster.
Other
22 stars 11 forks source link

Added aria-label to all tables to support Name property #227

Closed dabasnidhi closed 5 years ago

dabasnidhi commented 5 years ago

AriaLabel was recently added to Table props. It is not available in the most recent version (1.153.5) of azure-devops-ui package. Till the time it is not published we cannot start consuming it. So typecasting the table props adding aria label to them. Associated Bug 1554395: A11y_AzureDevOps_ServicesTab_K4D:Name property is missing for the table.

Also removed Ago and AgoBy strings from Resources as they are not consumed anywhere and were causing localization issues in languages like German as described in this bug

madhuv-msft commented 5 years ago

later we can add a test to check for the arialabel property.