search

microsoft / azserialconsole

Azure Serial Console
17 stars 11 forks source link

Implement readline/editline keybindings (e.g. ^W) #68

Closed LukeCarrier closed 4 years ago

LukeCarrier commented 5 years ago

At present, regardless of whether or not the serial console input is focused, pressing ^W (remove word) will result in the tab being closed. This is frustrating when you're trying to restore network connectivity from the serial console in a pinch as the keybinding is burned into muscle memory.

Tested in Firefox 68.0.4.

asinn826 commented 5 years ago

@LukeCarrier I liked the original title better :). We hear your pain, this is something we'll pick up. Thanks for the feedback!

asinn826 commented 4 years ago

I realize that this ask is still outstanding, and since I also feel strongly about this, I'll leave a quick comment here that due to a bunch of high pri behind-the-scenes work we're doing right now, this bug has been deprioritized. We did an initial investigation into this and the result of that was that this bug was going to be harder to fix than we initially thought. Deprioritizing this was a tough decision to make but I'll be pushing for this bug to get fixed when we get a chance.

asinn826 commented 4 years ago

Update - now you won't be able to shoot yourself in the foot with ^W: image

Note that you won't be able to remove word (that was trickier) but you won't be able to accidentally close the tab. This will work for any active serial connection (^W on loading screen will still close tab).

LukeCarrier commented 4 years ago

@asinn826, you're a hero.