Edits to Bicep files - Githubissues

johndowns commented 3 years ago

This PR updates the Bicep templates to follow best practices and Microsoft's style for Bicep code.

I also have added some comments to the PR to indicate a few things you might want to look at.

Feel free to contact me if you have any questions!

johndowns commented 3 years ago

Hey @MikeLarah, no worries!

I've given you write access to my fork.
Re the guid() vs newGuid() thing - yeah, I think I understand what you mean. If it's all done within the template then I agree that it's probably reasonable to use newGuid(), although there's still a race condition where on a subsequent deployment, you might update some of the references to the secret while others are still using the older version. It seems like a reasonable trade-off to me, but might be worth noting in the documentation that if you're going to go to production with this you should set that parameter explicitly (e.g. using a Key Vault secret) instead of relying on the default newGuid() value.

Thanks for the responses!

MikeEvansLarah commented 3 years ago

@johndowns I think I've addressed all the comments now. Do you want to give a quick once over before I merge the PR?

johndowns commented 3 years ago

@MikeLarah Looks good!

microsoft / azure-api-management-monetization