Feedback on Dev experience

[azaslonov]

A few thing I think we should fix/add:

• Mention NodeJS as a pre-requisite, and provide a link to download.
• We should add the CLI version (2.21.0+) which we know for sure will work with the script. Also mention "az upgrade".
• We should add references to docs for each CLI command.
• Deploy to Azure button doesn't work as-is (we need to check how to make it work after forking).
• Typo: --ArtifactStorageAccountName "" (should be one dash).
• Links to docs for "API Management", "App Service", "Web App for Containers", "Service Principal RBAC".
• Mention that you need to rename "main.parameters.template.json" to "main.parameters.json"
• Also, we need example values for each parameter in "main.parameters.json".
• In "main.parameters.json" // The client secret for the service principal": rename "secret" to "password" (the idea is to match wording to avoid unnecessary confusion):

  {
  "appId": "…",
  "displayName": "alzaslon-sp",
  "name": http://alzaslon-sp,
  "password": "…",
  "tenant": "…"
  }

• In "main.parameters.json" property "stripeApiKey" matches to "Initialization Key" or "App key"?
• We need to tell where to get those in Stripe:

      "checkoutSuccessfulUrl": {
          "value": ""
      },
      "checkoutCancelledUrl": {
          "value": ""
      }

[MikeEvansLarah]

Deploy to Azure button doesn't work as-is

This is because the repo is currently private. It links to the ARM template in the repo, so repo needs to be public for it to work.

@miaojiang there is also still the issue that we need to enable GitHub Container Registry on the repo in order to publish the web app container image (or use a different public container registry)

[MikeEvansLarah]

@miaojiang there is also still the issue that we need to enable GitHub Container Registry on the repo in order to publish the web app container image (or use a different public container registry)

GHCR has gone GA so it seems to be enabled by default now, so nothing further required for this.

[MikeEvansLarah]

These issues have all been addressed.