microsoft / azure-boards-estimate

MIT License
33 stars 24 forks source link

Non creator cannot estimate if "only creator can change work items and commit" is ticked #208

Closed nataliia-ckb closed 1 year ago

nataliia-ckb commented 1 year ago

Good morning!

When I create a new session and tick "Only creator can change work items and commit", my colleagues cannot click on any items to estimate them. The new page looks exactly as it should with all the user stories on the left, but you cannot click onto each item to actually see the details on the right side of the screen (when you hover on each item the cursor does not change to pointer).

I tested this by creating a new session, and asking my colleague to estimate the test work items. Then I asked them to create a new session and I was not able to estimate. Tried in 2 different projects.

If I create a session and do not tick "Only creator can change work items and commit" - everything works as expected.

We are on version 2.3.78 and tested again this morning.

nataliia-ckb commented 1 year ago

I can see the following error, but not quite sure if it's directly related - it appears both on working and non working pages.

{
"$id": "1",
"innerException": null,
"message": "%error=\"1660002\";%:The collection does not exist\r\n%error=\"1660002\";%:The collection does not exist",
"typeName": "Microsoft.VisualStudio.Services.ExtensionManagement.WebApi.DocumentCollectionDoesNotExistException, Microsoft.VisualStudio.Services.ExtensionManagement.WebApi",
"typeKey": "DocumentCollectionDoesNotExistException",
"errorCode": 0,
"eventId": 3000
}
AminTi commented 1 year ago

Hi! when you choose "Only creator can change" your colleagues can only vote. only the session owner can reveal change items etc...

nataliia-ckb commented 1 year ago

@AminTi they cannot vote, as they cannot open the item at all. Have a look at the screen recording https://user-images.githubusercontent.com/104978004/213208061-7300ede8-6d9e-4fa3-bdcb-bd052f8d3532.mov. This is a test session created by my colleague where she selected "only creator can estimate". As a result, I cannot open any of the cards to actually vote on them.

I was also poking the responses now and where I have created the session onlyCreatorCanSwitch variable is set to True and I can switch between items. But where my colleague has created the session with identical settings onlyCreatorCanSwitch variable is set to False and I cannot switch items at all.

EDIT: to mention this is an Offline session in both cases. The use case is that we give the team a day to vote at the time that works for them.

AminTi commented 1 year ago

@nataliia-ckb now I can reproduce it, this is an offline issue.

nataliia-ckb commented 1 year ago

@AminTi hey! Thank you very much for the new version! Unfortunately, just tested and getting the same issue :( Checked the commits and can't see the fix relating to this - maybe it got forgotten?

AminTi commented 1 year ago

which one of those extensions do you use? Screenshot 2023-02-07 at 17 24 13

nataliia-ckb commented 1 year ago

Oh, we are on Estimate. Should I try the Poker one?

nataliia-ckb commented 1 year ago

So I am using the right one. We are on the Estimate module :). I can see the "clear" field changes with the new update and already used it. However there seems to be no PR for this item in the code itself :(

AminTi commented 1 year ago

my bad, do you use VPN ?, I can not reproduce the issue, amin.titi@solidify.dev we can do a web session if you want.

nataliia-ckb commented 1 year ago

Thank you so much for looking into this. Let me just try to describe all the steps, maybe I missed something obvious. No VPN. Using Chrome 109.0.5414.119 (although tested in Safari initially and the same behaviour). Version:

Screenshot 2023-02-08 at 15 29 21

I could be wrong, but to me it looks like state management is not correct for the offline session. Have a look below.

Scenario 1 - Offline session with Creator Only Ticked

  1. Create a new session. Screenshot 2023-02-08 at 15 08 40

    (The query is quite basic, just getting Features in specific state where complexity is empty/not filled in. Complexity is where we store the outcome of estimation).

    Screenshot 2023-02-08 at 15 09 41
  2. Session is created Screenshot 2023-02-08 at 15 11 51
  3. As a creator I open the session and can click on items in it, estimate, save, etc. Screenshot 2023-02-08 at 15 13 04

    As a non creator on the same page I just cannot click on work items to reveal them (no link is available). So I cannot see card details / vote. This is what caught my eye - I get this response for this session:

    Screenshot 2023-02-08 at 15 18 09

    OUTCOME: non creator CANNOT open (click on / link is missing) any work items on the left and cannot vote. It's almost like it's treated as an online session and the creator is the only person who can click and change items on the screen.

Scenario 2 - Offline session with Creator Only Unticked IF I create a similar session with one difference - the creator tickbox - I get:

  1. Session: Screenshot 2023-02-08 at 15 46 13
  2. Session is created: Screenshot 2023-02-08 at 15 46 32
  3. Response: Screenshot 2023-02-08 at 15 46 51

OUTCOME: non creator can open work items and vote... But they can also save each other votes which creates chaos :)

I think in the first scenario onlyCreatorCanSwitch should actually be False to allow other team members switch / open items.

nataliia-ckb commented 1 year ago

@AminTi hey! Just wondering if you were able to replicate the issue? :)

AminTi commented 1 year ago

Hi @nataliia-ckb I add it to the backlog, for the moment I have to work on other extensions.
I will work on it as soon as possible.

nataliia-ckb commented 1 year ago

Thank you very much :) Sorry, was only checking as the item is closed so was curious as to whether the info was okay :)

AminTi commented 1 year ago

Thank you @nataliia-ckb I let you know if I need some logs.

nataliia-ckb commented 1 year ago

Hey @AminTi just wanted to ask whether you had a chance to look at this one :) Sorry, just had another case where one person in a team saved their vote for all the tickets, instead of just voting, so thought I'd ask!

AminTi commented 1 year ago

HI! Nataliia I Add it to the backlog.

AminTi commented 1 year ago

HI @nataliia-ckb, We conducted some tests, both independently and as a team, and found that the system performed as intended. By selecting the "Only the creator can change work items and commit" option, only the individual who created the session will be able to access certain functions such as opening links, revealing, saving, etc. Others will only have the ability to vote. Please inform me if you require further assistance.

nataliia-ckb commented 1 year ago

@AminTi oh I'm so sorry, I started testing and got completely overtaken by the work tasks. :( I'm really baffled by this, as we're still getting still the same issue.

As you're saying, I would expect that by selecting the "Only the creator can change work items and commit" option my team member would be able to vote, but not save, open links, etc. However, at the moment they cannot vote.

Using the following settings image

When I am the creator of the session, I get this:

https://github.com/microsoft/azure-boards-estimate/assets/104978004/02b5f975-2644-4701-8233-6e29eeb237b3

When my colleague created the session with the same setting, shared a link with me and I opened it to vote - I get this:

https://github.com/microsoft/azure-boards-estimate/assets/104978004/1dd598dc-7ba2-485d-8332-1b65a15f3503

Essentially, I just cannot click into to vote on any of the items.

I may be I'm doing something wrong, but I really can't see what - we are using just the online version of https://dev.azure.com/ (not on premises etc), got the latest version of the plugin.

The issue is only visible when one person creates a session and then the other person tries to vote on that session.

nataliia-ckb commented 1 year ago

Hey @AminTi just wondered if you got a chance to have a look at the videos above. We've just tested again and the behaviour is still the same - if I create a voting link and select that "only creator can change work items" none of my team members can vote :'( I really don't understand what is happening as we can't be the only ones having this issue.

AminTi commented 1 year ago

The person who started the session has to click on the ticket before the other person can vote.

nataliia-ckb commented 1 year ago

@AminTi thank you for your response! Could I just check, how it it possible in an offline session? Or do you mean I need to click through all of them before sending the link? Edit: essentially in our case we create the session and send it over to the team to vote over a few days at their own convenience.

AminTi commented 1 year ago

I can check and get back to you.

AminTi commented 1 year ago

Hi, @nataliia-ckb We will make an exception for offline sessions, it will be released next week.

nataliia-ckb commented 1 year ago

Oh this is incredible, thank you very much!!!! :)

AminTi commented 12 months ago

Hi @nataliia-ckb I just released an update now, It will work for your team now

nataliia-ckb commented 10 months ago

@AminTi tested on a few voting rounds now and it works perfectly 🎉 Thank you very very much. 🧁

nataliia-ckb commented 7 months ago

Hi @AminTi! The fix worked perfectly until the last release 😭 We are on 2.3.90 and stopped working again - same behaviour as initially described - non creator cannot open and vote on items in offline estimate mode 😭 Our last round of voting was on 10 Jan 2024, it worked perfectly. Then with the same link the team members were no longer able to vote. Perhaps something added in the last release that messed up the fix?

AminTi commented 7 months ago

Hi @nataliia-ckb! I wanted to inform you that the issue has been successfully resolved, and we are scheduled to release the fix on Monday. If you encounter any problems with the extension, please create a new issue for prompt attention.

Thank you for your cooperation and understanding.