search

microsoft / azure-boards-estimate

MIT License
34 stars 24 forks source link

fix: Move URI resolution to `render() method` #90

Closed hangy closed 2 years ago

hangy commented 2 years ago

componentDidMount() is called once for each component. We can use it to initialize the ILocationService, but the workItemUrl needs to be evaluated for each work item, so it has now been moved to the render() method.

Fixes #88

hangy commented 2 years ago

I cannot test this right now, but this approach (in general) should fix the linked issue.

hangy commented 2 years ago

I just noticed that #85 tackles the same issue in a bit different way. Feel free to choose whichever is the better approach. 🙂

MOlausson commented 2 years ago

Thanks for your help @hangy ! We decided to go for the fix in #92 but your input helped to evaluate the options. New release coming soon!