search

microsoft / azure-devops-intellij

IntelliJ IDEA plug-in for Visual Studio Team Services and Team Foundation Server (TFS)
MIT License
151 stars 95 forks source link

Do not require "TeamServicesUrl" for SSH to HTTPS conversion #433

Closed koendelaat closed 3 years ago

koendelaat commented 3 years ago

I think we don't need a check for TeamServicesUrl, so this will work for on premise deployments of ADS

351

176

ForNeVeR commented 3 years ago

Hello, @koendelaat. Could you please elaborate: what do you expect to change after this patch being applied? How do we test the changes? What use cases do you target by this patch?

I am concerned because this is a very core API which is called across many authentication-related functions, and changing it may have quite a few implications, including the security-related ones.

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

koendelaat commented 3 years ago

This was a blocking issue for me using an on-premise deployment of Azure Devops Server. This on-premise server doesn't have any of the VSO, TFS or AZURE constants in the url. So deriving the https url from ssh was impossible. I don't see why the url should contain any of these constants to do the conversion. I've also added a test to show the use-case and functionality.

koendelaat commented 3 years ago

@ForNeVeR Is the usecase and solution clear? Or do you have other concerns?

ForNeVeR commented 3 years ago

I have checked out the changes, and they seem to work well for me: i.e. they don't affect the usual operation of Git, and I am able to clone Git repositories from both Azure DevOps and outside.

Do they work well for your on-premise server, though?

koendelaat commented 3 years ago

With this fix the plugin works as expected on the on-premise server.

ForNeVeR commented 3 years ago

Thanks for help! We'll include this change in the next release.