microsoft / azure-devops-intellij

IntelliJ IDEA plug-in for Visual Studio Team Services and Team Foundation Server (TFS)
MIT License
151 stars 94 forks source link

Improve executable file detection in settings #436

Open shaokuuipo opened 3 years ago

shaokuuipo commented 3 years ago

com.microsoft.alm.plugin.external.exceptions.ToolException: KEY_TF_EXE_NOT_FOUND at com.microsoft.alm.plugin.external.tools.TfTool.getValidLocation(TfTool.java:80) at com.microsoft.alm.plugin.external.commands.Command.run(Command.java:143) at com.microsoft.alm.plugin.external.commands.Command.runSynchronously(Command.java:223) at com.microsoft.alm.plugin.idea.tfvc.ui.settings.EULADialog.executeWithGuard(EULADialog.java:226) at com.microsoft.alm.plugin.idea.tfvc.ui.checkout.TfvcCheckoutModel$1.run(TfvcCheckoutModel.java:91) at com.intellij.openapi.progress.impl.CoreProgressManager$TaskRunnable.run(CoreProgressManager.java:998) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcessWithProgressAsync$5(CoreProgressManager.java:497) at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$3(ProgressRunner.java:228) at com.intellij.openapi.progress.impl.CoreProgressManager.lambda$runProcess$2(CoreProgressManager.java:178) at com.intellij.openapi.progress.impl.CoreProgressManager.registerIndicatorAndRun(CoreProgressManager.java:688) at com.intellij.openapi.progress.impl.CoreProgressManager.executeProcessUnderProgress(CoreProgressManager.java:634) at com.intellij.openapi.progress.impl.ProgressManagerImpl.executeProcessUnderProgress(ProgressManagerImpl.java:64) at com.intellij.openapi.progress.impl.CoreProgressManager.runProcess(CoreProgressManager.java:165) at com.intellij.openapi.progress.impl.ProgressRunner.lambda$submit$4(ProgressRunner.java:228) at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:668) at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1$1.run(Executors.java:665) at java.base/java.security.AccessController.doPrivileged(Native Method) at java.base/java.util.concurrent.Executors$PrivilegedThreadFactory$1.run(Executors.java:665) at java.base/java.lang.Thread.run(Thread.java:834)

ForNeVeR commented 3 years ago

Hello. Have you set up a TFVC client in the IDE settings?

shaokuuipo commented 3 years ago

I set TEE-CLC-14.135.0

ForNeVeR commented 3 years ago

@shaokuuipo, and you still experience the issue? Could you please show a settings screenshot?

shaokuuipo commented 3 years ago

Thank you Only set TEE-CLC-14.135.0 Still not work

1 2 3

ForNeVeR commented 3 years ago

You should set it as the full path to the tf.cmd file, not to the directory.

That's a valid point, though. The plugin could've guessed the name of the executable after you selected the directory.

For now, try D:\developer\TEE-CLC-14.135.0\tf.cmd, it should work.

shaokuuipo commented 3 years ago

It's worked, thank you.

ForNeVeR commented 3 years ago

I'll keep the issue open and transform it into a feature request: let's allow the users to choose the TFVC client directory in settings, and detect the executable file (tf or tf.cmd) automatically.