microsoft / azure-pipelines-agent

Azure Pipelines Agent 🚀
MIT License
1.7k stars 855 forks source link

[Question]: what is correct run script for running in docker #4435

Open MirKml opened 9 months ago

MirKml commented 9 months ago

Describe your question

Hi, I read the doc about running agent in docker on linux https://learn.microsoft.com/en-us/azure/devops/pipelines/agents/docker?view=azure-devops#linux

there is starup.sh script which ends with ./run.sh "$@" & wait $!

But there is an issue https://github.com/microsoft/azure-pipelines-agent/pull/3636 which creates the run-docker.sh and recommended it as replacement for run.sh. It's still presented on latest agent. But in the documentation, run.sh is presented but it received no updates.

So what is the best script to run the agent? I think run-docker.sh - it's younger and fix some issue. But in documentation older one run.sh is mentioned.

Versions

latest 3.x Azure pipeline agent for Linux

Environment type (Please select at least one enviroment where you face this issue)

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Operation system

Linux with docker

Version controll system

No response

Azure DevOps Server Version (if applicable)

No response

ismayilov-ismayil commented 9 months ago

Hi @MirKml, thanks for reporting. We will look and update the doc if necessary.

frankhaugen commented 6 months ago

Hi @MirKml, thanks for reporting. We will look and update the doc if necessary.

This is still unresolved?

MirKml commented 6 months ago

This is still unresolved?

@frankhaugen I think unresolved. We still use run-docker.sh, it's presented in latest agent release. It was set up by previous developer.

Nothing mentioned in doc about difference run.sh vs run-docker.sh

github-actions[bot] commented 5 days ago

This issue has had no activity in 180 days. Please comment if it is not actually stale