microsoft / azure-pipelines-extensions

Collection of all RM and deployment extensions
http://www.visualstudio.com/explore/release-management-vs
MIT License
275 stars 425 forks source link

Improve additional arguments validation to allow array of parameters #1156

Closed LeftTwixWand closed 1 year ago

LeftTwixWand commented 1 year ago

Extension name: IISWebAppDeploy

Tasks:

Description: Before, during the additional arguments validation we just looked for the forbidden characters, like this:

if($additionalArguments -match "[&;|]")

But there is some cases, when we have to pass some array of values as a parameter argument, like this:

/p:DoNotDropObjectTypes="RoleMembership;ServerRoleMembership"

This PR improves validation, by skipping the content in quotes.

Documentation changes required: No

Added unit tests: Yes

Attached related issues:

Checklist: