search

microsoft / azure-pipelines-extensions

Collection of all RM and deployment extensions
http://www.visualstudio.com/explore/release-management-vs
MIT License
275 stars 425 forks source link

IISWebAppMgmtV3 - Bypass bindings with duplicate certificates & support multiple certificates #1220

Closed v-venunayira closed 5 months ago

v-venunayira commented 5 months ago

Description: Bypassing addition of SSL binding with an existing certificate.

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: https://github.com/microsoft/azure-pipelines-extensions/issues/919

Checklist:

LeftTwixWand commented 5 months ago

LGTM, but @LeftTwixWand can you confirm if bumping of task version for V1 and V2 is required? Hey @v-mohithgc it's not required, but it would be good to have the same version for all the tasks, just not to mess up in case of a problem.

jabteles commented 5 months ago

Hey @LeftTwixWand and thanks for this fix! But when will it be available as a release in the Azure/Visual Studio Marketplace so we can download to our on-premises installations?

LeftTwixWand commented 5 months ago

Hello @jabteles we've just released a new version of the extension. The ADO should automatically catch up the update of the extension and install it.

jabteles commented 5 months ago

Hello @jabteles we've just released a new version of the extension. The ADO should automatically catch up the update of the extension and install it.

I updated the extension on my Azure DevOps and still get the same error. I've confirmed it is using correct version (3.2.0)

naillatem commented 4 months ago

The extension fails on target server from other localizations. Parsing the nesth http show sslcert command output with an unlocalized string, like "IP:port" doesn't work on target servers with different localization configuration (i.e. spanish output shows "IP:puerto", and Add-SslCert function fails when trying to add an existing certificate binding).

PhilBlackRose commented 4 months ago

@v-schhabra Thanks for hint to try this to fix issues with IIS web deploy task, This task however doesn't seem compatible with Deployment Group jobs?

v-schhabra commented 1 month ago

Hello @jabteles we've just released a new version of the extension. The ADO should automatically catch up the update of the extension and install it.

I updated the extension on my Azure DevOps and still get the same error. I've confirmed it is using correct version (3.2.0)

@jabteles Could you share the logs of the pipeline by adding variable system.debug to "true"