search

microsoft / azure-pipelines-jira

Azure Pipelines for Jira
MIT License
15 stars 6 forks source link

Stage -> Deployment type mapping(s) incorrect after save #11

Closed tobyreid closed 4 years ago

tobyreid commented 5 years ago

Describe the bug

When mapping the (classic) Azure pipeline Stage to JIRA Deployment type it appears to save successfully, but after page refresh - it shows the incorrect values..

To Reproduce

I have 3 Stages in my pipeline, Integration, Staging and Production - when mapping these as follows and clicking save, observe the desired output:

image

The response from vsrm.dev.azure.com comes back with a json response that causes the interface to show the following (only visible after a full page refresh)

image

It appears that all desired values I entered have had their index shifted by -1 relative to their Stage.

Looking at Fidder, the properties and values for the Stage-> Deployment type mapping appear to be saved as child properties of the correct 'Stage', but the response is incorrect:

image

Expected behavior To save the properties of the Stage with correct values

Screenshots See above inline

Desktop (please complete the following information):

tobyreid commented 5 years ago

I'll add that this occurs where there is a dependency between stages:

image

*edit - Actually it occurs all the time

EricStG commented 5 years ago

We have the same issue in our pipeline image

shashban commented 5 years ago

Thanks for reporting. We'll get this checked.

shyama1208 commented 5 years ago

@tobyreid Sorry for the inconvenience. We are unable to reproduce this issue. Below are the steps that we tried:

  1. Create an RD with 3 stages. The stages have same dependency as in the screenshot shared by you.
  2. Turn on "Report deploymnet status to Jira" option and configure the deployment types for each stage.
  3. Save the RD and refresh the page.

Can you please help us with the exact repro steps.

tobyreid commented 5 years ago

Hi @shyama1208,

Sorry for the delayed response -

With regard to repro steps - I can capture the payload that's being sent to the server via PUT - it appears to be "correct" from my inspection. The response from the server is incorrect. Would you like examples of that?

I have a few other build pipelines where this behaviour isn't exhibited, I cannot determine the common factor.

shyama1208 commented 5 years ago

Never mind. We got the repro and we have fixed the issue. The fix should be deployed in few weeks. Thanks for bringing up the issue!

tobyreid commented 5 years ago

👍 Thanks @shyama1208

tobyreid commented 5 years ago

This appears to be working now (for me) in Azure DevOps

EricStG commented 5 years ago

Same here

shyama1208 commented 5 years ago

Thanks for confirming!

prativen commented 4 years ago

Thanks for reporting the issue. Closing this as this is now fixed